Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trustingAllHosts should be public on the Builder API #135

Closed
MartinVerges opened this issue Apr 3, 2018 · 2 comments
Closed

trustingAllHosts should be public on the Builder API #135

MartinVerges opened this issue Apr 3, 2018 · 2 comments
Assignees
@bbottema
Labels
bug Priority-High
Milestone
5.0.2

Comments

@MartinVerges
Copy link

trustingAllHosts in the builder used to be public but it's private since eaa7677#diff-2ccc25806b11b5b4c660efb12c8a4d1aR362

should it be public?
@bbottema bbottema self-assigned this Apr 7, 2018
bbottema added a commit that referenced this issue Apr 7, 2018
@bbottema
#135: trustAllHosts(boolean) should be public API
c37a46d
@bbottema
Copy link
Owner

bbottema commented Apr 7, 2018

Indeed, seems like an oversight on my part. Thanks for the heads up.

@bbottema bbottema closed this as completed Apr 7, 2018
@bbottema bbottema changed the title trustingAllHosts is private trustingAllHosts should be public on the Builder API Apr 7, 2018
@bbottema
Copy link
Owner

bbottema commented Apr 7, 2018

Fixed in 5.0.2.

@bbottema bbottema added this to the 5.0.2 milestone Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbottema bbottema

Labels
bug Priority-High
Projects
None yet
Milestone
5.0.2
Development

No branches or pull requests
2 participants
@bbottema @MartinVerges