Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate can throw exception ; deallocation should not be impacted. #5

Merged
merged 1 commit into from
May 3, 2024
Merged

Allocate can throw exception ; deallocation should not be impacted. #5

merged 1 commit into from
May 3, 2024

Conversation

rahulbhawsar
Copy link
Contributor

it's been observed that deallocation is not happening due to allocation issues and , which left the many open connections at the server.

@rahulbhawsar
Copy link
Contributor Author

rahulbhawsar commented May 3, 2024

@bbottema could you please review this on priority ,
we have observed that -

  1. when we are using simple java mail - and high number of suppressed emails encountered.
  2. during this time many errors ocurres and smtp connections are invalidated.
  3. Since our pool is 100 only, and our smtp server doesn't allows the new connections until invalidated connections are closed.
  4. and allocator starts throwing the exception, as 100 limit is reached, at the same time deallocation doesn't happen as allocator is throwing exception.
  5. we are seeing this issue in production env , hence want this to be reviewed and merged.

bbottema added a commit that referenced this pull request May 3, 2024
@bbottema bbottema merged commit cd65406 into bbottema:master May 3, 2024
1 check passed
@bbottema
Copy link
Owner

bbottema commented May 3, 2024

Fix released in 2.1.0. I'm in the process of updating the dependencies downstream (clustered-object-pool and smtp-connection-pool) so I can update Simple Java Mail.

@bbottema
Copy link
Owner

bbottema commented May 3, 2024

It took a bit of work to update clustered-object-pool, smtp-connection-pool and simple-java-mail, also because I updated their parent poms which upgrades from Junit 4 to Junit 5, but it's done. The fix is released in Simple Java Mail v8.10.1 (bbottema/simple-java-mail#510).

Was that fast enough? ;) -- and btw, thank you for investigating this and coming up with the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants