This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
Native + annotations fixes, sdk update. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix an issue with the method reflection catching that would cause some nodes to be dropped and an infinite recursion problem on one file. - Added issue_19.cpp fixture to avoid regresions of that problem. - Fix the `FunctionGroup` annotation when there is an elaborated type in the arguments. - Update to latest SDK. Signed-off-by: Juanjo Alvarez <[email protected]>
dennwc
approved these changes
Feb 7, 2019
| {Name: "Prop_Name", Op: Var("aname")}, | ||
| {Name: "Prop_Initializer", Optional: "optInitializer", Op: Var("ainit")}, | ||
| {Name: "Kind", Op: Var("eltype")}, | ||
| {Name: "IsConst", Op: Any()}, |
There was a problem hiding this comment.
It would be nice to move those nodes to a wrapper node on Type (in a different PR).
There was a problem hiding this comment.
Yep, the fields were so slightly different between types that it almost wasn't worth it but with these new ones I think it is.
Signed-off-by: Juanjo Alvarez <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with the method reflection catching that would cause some nodes to be
dropped (mostly when they were under the
Prop_DeclSpecifierproperty but also in some other cases) and an infinite recursion problem on one file.Added issue_19.cpp fixture to avoid regresions of that problem.
Fix the
FunctionGroupsemantic annotation when there is an elaborated typein the arguments.
Update to latest SDK.
Fixes #19.
Signed-off-by: Juanjo Alvarez [email protected]