Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: std::string is not declared #1967

Closed
margaretselzer opened this issue Sep 13, 2023 · 2 comments
Closed

error: std::string is not declared #1967

margaretselzer opened this issue Sep 13, 2023 · 2 comments
Labels

Comments

@margaretselzer
Copy link

margaretselzer commented Sep 13, 2023

Description
I have a rather complex Arduino project where I use ArduinoJson. When using version 6.19.4 the code compiled without any problems. We have updated now to ArduinoJson 6.21.3 and get build errors. The first build error is "/ArduinoJson/Variant/ConverterImpl.hpp:283:51: error: 'std::string' has not been declared" and then as a result there is a massive number of other errors. The problem can be fixed by including <string> before ArduinoJson.h, however I believe that the ArduinoJson library should be able to manage its own dependencies.

I propose a fix in the "Reproduction Code" section.

Troubleshooter's report

  1. The issue happens at compile time
  2. The error is not in the list

Environment

Reproduction code

/***********************************************/
/* This is a suggestion for fixing the problem */
/*                                             */
/* Modify Configuration.hpp as per below       */
/***********************************************/

// Support std::string
#ifndef ARDUINOJSON_ENABLE_STD_STRING
#  ifdef __has_include
#    if __has_include(<string>) && !defined(min) && !defined(max)
#      include <string>
#      define ARDUINOJSON_ENABLE_STD_STRING 1
#    else
#      define ARDUINOJSON_ENABLE_STD_STRING 0
#    endif
#  else
#    ifdef ARDUINO
#      define ARDUINOJSON_ENABLE_STD_STRING 0
#    else
#      define ARDUINOJSON_ENABLE_STD_STRING 1
#    endif
#  endif
#endif

Remarks
I suggest to do the same for <string_view> and any other STL type used by ArduinoJson.

@bblanchon
Copy link
Owner

Hi @margaretselzer,

Thank you very much for reporting this bug 👍
It's fixed in the 6.x branch.

Best regards,
Benoit

bblanchon added a commit that referenced this issue Sep 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
@bblanchon
Copy link
Owner

The fix was published with ArduinoJson 6.21.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants