Resolve radash module & upgrade nuxt to the latest #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- using resolver from nuxt kit fixes radash types
Open
|
@bbg Please review when you find some time! 🙏 Thanks! |
lukasaric
commented
Sep 25, 2023
| @@ -63,7 +65,7 @@ export default defineNuxtModule<ModuleOptions>({ | |||
| const as = prefix | |||
| ? prefix + (options.upperAfterPrefix ? radash.pascal(alias) : alias) | |||
| : alias; | |||
| addImports({ name, as, from: "radash" }); | |||
| addImports({ name, as, from: resolve("./runtime/radash") }); | |||
There was a problem hiding this comment.
fyi, Tried to use findPath + resolve from nuxt/kit to directly resolve radash here, but it seems that it does not work. That's why I just exported everything through ./runtime/radash.ts file and resolved it on my own.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createResolver().resolvefrom@nuxt/kitso that theradashhas properly resolved typesNuxtto the3.7.3