Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when instanciating a PolylineDecorator on a Polyline array #68

Closed
marcagba opened this issue Oct 4, 2017 · 2 comments
Closed
Labels

Comments

@marcagba
Copy link

marcagba commented Oct 4, 2017

What:
Instanciating PolylineDecorator on a Polyline array result on an error.

Why:
This is due to a typo error in the internal function _initPaths in charge of harmonizing the paths given to the PolylineDecorator.

A PR is coming to fix this issue.

marcagba pushed a commit to marcagba/Leaflet.PolylineDecorator that referenced this issue Oct 4, 2017
What:
Instanciating PolylineDecorator on a Polyline array result on an error.

Why:
This is due to a typo error in the internal function _initPaths in charge
of harmonizing the paths given to the PolylineDecorator.

How:
Fix the typo error in the _initPath function.

Refs: bbecquet#68
@bbecquet
Copy link
Owner

Hi!
Thanks a lot for spotting it and proposing a fix. And sorry I've taken so damn long to look at it. I'm gonna merge the PR. And it also motivated me to refactor this part completely, as it's by far the ugliest and untested part remaining.
Thanks again.

@bbecquet bbecquet added the bug label Oct 15, 2017
@marcagba
Copy link
Author

You're welcome ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants