Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding the ability to pass a function to terminateVisibilityTimeout #553

Merged

Conversation

nicholasgriffintn
Copy link
Member

@nicholasgriffintn nicholasgriffintn commented Jan 4, 2025

Description:

This adds the ability to pass a function to terminateVisabilityTImeout, which allows you to do exponential backoff based on parameters in the messages (this is always an array even if you don't use batches).

Props to the Vercel fork of SQS Consumer where I noticed and grabbed this from: vercel#1, makes a whole ton of sense.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@nicholasgriffintn nicholasgriffintn requested review from a team as code owners January 4, 2025 01:39
Copy link

github-actions bot commented Jan 4, 2025

LCOV of commit 6a1c8e0 during Comment PR Coverage #91

Summary coverage rate:
  lines......: 97.1% (893 of 920 lines)
  functions..: 100.0% (34 of 34 functions)
  branches...: 94.3% (166 of 176 branches)

Files changed coverage rate:
                   |Lines       |Functions  |Branches    
  Filename         |Rate     Num|Rate    Num|Rate     Num
  =======================================================
  src/consumer.ts  |96.4%    660| 100%    21|93.9%    132

@nicholasgriffintn nicholasgriffintn merged commit 62d12bc into canary Jan 4, 2025
13 checks passed
@nicholasgriffintn nicholasgriffintn deleted the support-terminateVisibilityTimeout-function branch January 4, 2025 01:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant