Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding MessageSystemAttributeNames #518

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

nicholasgriffintn
Copy link
Member

Resolves #515

Description:

This adds the ability to provide MessageSystemAttributeNames for SQS, it will be passed from options to SQS.

More information is available on the docs: https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/Package/-aws-sdk-client-sqs/Interface/ReceiveMessageCommandInput/

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:

Because we didn't have it yet

@nicholasgriffintn nicholasgriffintn requested review from a team as code owners October 1, 2024 20:06
Copy link

github-actions bot commented Oct 1, 2024

LCOV of commit d4bdb7a during Comment PR Coverage #33

Summary coverage rate:
  lines......: 98.0% (876 of 894 lines)
  functions..: 100.0% (34 of 34 functions)
  branches...: 94.2% (162 of 172 branches)

Files changed coverage rate:
                   |Lines       |Functions  |Branches    
  Filename         |Rate     Num|Rate    Num|Rate     Num
  =======================================================
  src/consumer.ts  |97.6%    634| 100%    21|93.8%    128

@nicholasgriffintn nicholasgriffintn merged commit c35eb4c into canary Oct 1, 2024
12 of 13 checks passed
@nicholasgriffintn nicholasgriffintn deleted the MessageSystemAttributeNames-support branch October 1, 2024 20:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: RetrieveMessage is missing the MessageSystemAttributeNames parameter
1 participant