Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: removing handler_processing debugger in favour of status #470

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

nicholasgriffintn
Copy link
Member

Resolves #469

Description:

The PR removes the debugger that was previously added that would send a handler_processing debug log every second while polling was ongoing.

This is no longer required as the new status method returns this information.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:

This simplifies the codebase and makes it easier for us to maintain, and to understand.

Code changes:

  • Removes the handler_processing debugger
  • Changes waiting_for_polling_to_complete and waiting_for_polling_to_complete_timeout_exceeded to emit so users can react to them easier
  • Fixes some flaky test issues

Copy link

codeclimate bot commented Mar 11, 2024

Code Climate has analyzed commit 16a08db and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.3% (0.0% change).

View more on Code Climate.

@nicholasgriffintn nicholasgriffintn merged commit b554da6 into main Mar 11, 2024
7 checks passed
@nicholasgriffintn nicholasgriffintn deleted the remove-polling-debugger branch March 11, 2024 19:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the handler_processing debugger
1 participant