-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade @aws-sdk/client-sqs to version which supports sqs json protocol #440
chore: upgrade @aws-sdk/client-sqs to version which supports sqs json protocol #440
Conversation
The localstack upgrade is required since the previous version did not support the SQS JSON protocol as it was old; only the 'latest' tagged image seems to work properly (localstack/localstack#9607). The healthcheck path and init script path also changed with in more recent versions of localstack and it is also unnecessary to mount a tmp dir. More recent versions of docker also have a 'compose' subcommand instead, so I updated the initIntTest.sh script for that; let me know if this is somehow breaking in CI or something. This change should be fully compatible with AWS SQS APIs, it's only in localstack that issues appear. The benefit of this update is that "based on AWS performance tests for a 5KB message payload, JSON protocol for Amazon Simple Queue Service reduces end-to-end message processing latency by up to 23% and reduces application client side CPU and memory usage." |
Our CLA check is broken for some reason so I'll just have to do that manually...
|
I have read the CLA Document and I hereby sign the CLA |
Code Climate has analyzed commit 9d8cc91 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 98.2% (0.0% change). View more on Code Climate. |
To note: This would require a major version of the package as the new version of aws-sdk is breaking against anything that's expects the XML protocol. |
Localstack V2 deprecated the HOST_TMP_FOLDER and DATA_DIR envs. The DATA_DIR env was replaced with a PERSISTENCE env, but that is a paid feature of localstack now.
@nicholasgriffintn |
The localstack healthcheck endpoint now gives back a JSON object with a status for each service. This change makes it so that the healthcheck passes if the SQS service is in 'running' state.
Hey thanks for the updates and sorry, I've been super busy this week, I'm gonna slot some time to look into this on Friday hopefully, if not before. |
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
This was signed here: #440 (comment) |
Destroyed previously created lock and re ran to ensure it's BBC generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description:
Updates the aws sdk to a version which supports the AWS SQS JSON protocol.
Type of change:
Why is this change required?:
It enables better performance due to usage of the AWS SQS JSON communication protocol instead of the AWS SQS Query protocol between client and server.
Code changes:
Checklist: