Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typescript enhancements #337

Merged
merged 2 commits into from
Dec 18, 2022
Merged

chore: typescript enhancements #337

merged 2 commits into from
Dec 18, 2022

Conversation

nicholasgriffintn
Copy link
Member

@nicholasgriffintn nicholasgriffintn commented Dec 17, 2022

Description:

At the moment, we declare types within the same file as the main source code, and then export them individually, we should change this so that all types are declared in a single file and then exported at one.

Changes:

  • Moved ConsumerOptions and Events from the consumer file to the types file
  • Export everything from the types file automatically

@nicholasgriffintn nicholasgriffintn requested review from a team as code owners December 17, 2022 23:57
@nicholasgriffintn nicholasgriffintn added this to the 6.1.0 milestone Dec 18, 2022
@nicholasgriffintn nicholasgriffintn merged commit 6d5df09 into main Dec 18, 2022
@nicholasgriffintn nicholasgriffintn deleted the types-enhancements branch February 15, 2023 23:08
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant