Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NonExistentQueue to isConnectionError #336

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

nicholasgriffintn
Copy link
Member

@nicholasgriffintn nicholasgriffintn commented Dec 16, 2022

Resolves #273

Description:

Adds the NonExistentQueue error code to the isConnectionError so that polling will be timed out if it occurs, like other connection errors

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:
A simple explanation of what the problem is and how this PR solves it

Code changes:

  • Extended the isConnectionError function to check if the error code is AWS.SimpleQueueService.NonExistentQueue

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nicholasgriffintn nicholasgriffintn requested review from a team as code owners December 16, 2022 22:54
@nicholasgriffintn nicholasgriffintn added this to the 6.1.0 milestone Dec 16, 2022
@nicholasgriffintn nicholasgriffintn merged commit d6866ed into main Dec 17, 2022
@nicholasgriffintn nicholasgriffintn deleted the add-NonExistentQueue-timeout branch February 15, 2023 23:09
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No standoff on queue errors
1 participant