-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ack partial of a batch of messages #255
Conversation
I'd love to see this PR merged 🙏 |
This would be really helpful |
I am waiting for merge this pull request :) |
Any feedback if it will be merged? And if yes, when will it be? |
I need this too. Anyone using this lib needs it, is the only way to process in batch and handle erros. |
Would be nice to see this getting merged :-) |
We would be really chuffed if this would be merged ;) Any status on this? |
I see there are a fair amount of comments on this, however, it is out of date by a little, would be good to update this and then we can look at it in a future milestone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally and it works as expected.
I have updated this to work with AWS SDK V3 and I've also added a test for if handleMessageBatch returns void, which should delete all of the messages.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Description
When providing a handleMessageBatch function, code currently allows ack all messages or throw an error which will reject all messages.
The fix allows the user to return an array of successful messages which will be deleted from the queue, the rest of the messages will return to the queue
Motivation and Context
Added for personal use and response to issue 245
#245
Types of changes
Checklist: