Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INCONSISTENT CODE AND NOTES + TYPOGRAPHICAL ERROR IN 'CAROUSELS' PAGE #163

Open
ShuyiOlutimi opened this issue Jul 20, 2021 · 0 comments
Open

INCONSISTENT CODE AND NOTES + TYPOGRAPHICAL ERROR IN 'CAROUSELS' PAGE #163

ShuyiOlutimi opened this issue Jul 20, 2021 · 0 comments

Comments

@ShuyiOlutimi
Copy link

In the 'Notes' section explaining Carousels at https://bbc.github.io/gel/components/carousels/, there is an issue.

The Gel SVGs in the 'Recommended Markup' have the dual attributes of aria-hidden="true" and focusable="false"
image

However the 'Notes' explaining the markup notes that the SVGs have "aria-hidden="true" and scrollable="flase" to hide them from assistive technologies and remove them from focus order"
image

Please look to fix it.
mathalete added a commit that referenced this issue Feb 20, 2024
@mathalete
Fixing typos
034d19b 
Addressing #163 typo and scrollable="flase"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ShuyiOlutimi