Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Dash.js rendered subtitles #352

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ryanmccartney
Copy link

📺 What

Extends subtitle functionality by adding the ability to use Dash.js rendered subtitles if declared in an MPD rather than using the existing side-chain.

Allows the rendering of subtitles delivered in fragmented chunks, as used for low-latency playback.

It does not implement the current customisation options that are available in the existing side-chain as Dash.js provides no interface to access the customisation options present in the BBC fork of imscJS.

A currently open PR imscJS #257 would enable customisation on upstream imscJS and work on Dash.js (imscJS Styling would allow this functionality to be added retrospectively.

🛠 How
By setting a new override - dashSubtitles, the side-chain is replaced by a new dashsubtitles object which enables text tracks in the MSE player

✅ Testing [Semi-optional]

Tests have been added to cover changes to the subtitle selector. In addition, coverage of the new dashsubtitles.js object is provided.

Test Guidelines

Test engineer sign off

♿ Accessibility [optional]

Provides optional subtitles when using low-latency playback through Bigscreen player without modifications to the existing side-chain rendering.

@ryanmccartney ryanmccartney requested a review from a team as a code owner September 27, 2024 13:40
Copy link
Contributor

@eirikbjornr eirikbjornr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall! Got one question on setSubtitles and disableTextTracks

src/playbackstrategy/msestrategy.js Show resolved Hide resolved
@matt-stephenson
Copy link
Contributor

Just a thought on naming. I wonder if embeddedSubtitles might be a little clearer. Although it does work, as subtitles are in the dash manifest, the current side-loading of subs still happens during DASH playback.

@ryanmccartney
Copy link
Author

Just a thought on naming. I wonder if embeddedSubtitles might be a little clearer. Although it does work, as subtitles are in the dash manifest, the current side-loading of subs still happens during DASH playback.

That makes sense, I'll adjust the naming to reflect this

@ryanmccartney
Copy link
Author

References to Dash.js subtitles have now been updated to Embedded subtitles

@tom-coward tom-coward added the semver minor This PR is a semver minor release label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver minor This PR is a semver minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants