Style/AndOr enhanced autocorrect for method a or method a,b to method(a)||method(a,b)

[vrthra]

I am trying to get Style/AndOr cop to autocorrect on patterns like method a,b or method c to method(a,b) || method(c). I see that there is no change in AST between the old method a,b or method c and new method(a,b)||method(c), however I am at a loss how to implement it.

I see that the or node's two child expressions can be checked for node.loc.begin if the parenthesis exists, but I dont understand what to do when it does not.

[jonas054]

The closing parenthesis is the easiest. You just need to find the node representing the last argument, which you do with

receiver, method_name, *args = *node

and then use insert_after in autocorrect.

The opening parenthesis is a bit trickier. You could use insert_before and give args.first.loc.expression as argument, but there will be a space that we don't want before the parenthesis. A solution might need to include creating a new Range object and using the length of the method name when calculating its starting position.

[vrthra]

@jonas054 Thank you for the hints, I found that I can get it to work if I replace the method name with method( and then apply the insert_after with ')'. Does that sound Ok? or is it better to go with creating a new Range as you mentioned?

[jonas054]

If you can get it to work, I think it's fine. I thought that the method name was just a symbol, not a node, so that it would be necesary to construct a new Range object. It will be easier to say for sure when there's code to examine. So make a pull request when you have a solution ready, and we'll review it.

[vrthra]

Here is the code to go with it