Fix #1259 : Enable parenthesizing for andor autocorrect #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage increased (+0.0%) when pulling 236f59610d739a47e2916cc7fb54a6f7b2af5b34 on vrthra:fix/1259 into b5ef23a on bbatsov:master. |
|
Coverage increased (+0.0%) when pulling 0c6ad127dd6c67172cd724a45f3b6c5685c42945 on vrthra:fix/1259 into b5ef23a on bbatsov:master. |
vrthra
changed the title
| expect(new_source).to eq('method( a,b ) || b') | ||
| end | ||
|
|
||
| it 'auto-correct "or" with || and dont add extra parenthesis' do |
There was a problem hiding this comment.
Should be 'auto-corrects "or" with || and doesn't add extra parenthesis'
|
You should also add a changelog entry and rebase on top of the current master branch. |
This change allows rubocop to parenthesize method calls so that `method a,b or method c` can be autocorrected to `method(a,b) || method(c)`
|
@bbatsov updated with spelling correction, changelog and others |
|
👍 |
bbatsov
added a commit
that referenced
this pull request
Aug 13, 2014
Fix #1259 : Enable parenthesizing for andor autocorrect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows rubocop to parenthesize method calls so that
method a,b or method ccan be autocorrected tomethod(a,b) || method(c)