Mode --firmware also checks --storage -> Request error: No array controller data returned for API URL '/redfish/v1/Systems/1//SmartStorage/ArrayControllers?$expand=.'

[lgmu]

Hi,
we have a problem when using --firmware, because it also tries to check the storage and array controllers

https://github.com/bb-Ricardo/check_redfish/blob/next-release/cr_module/firmware.py#L128

The --storage doesn't work on the HPE ProLiant BL460c Gen9 with BIOS: I36 v2.74 (07/21/2019):
[UNKNOWN]: No storage controller and disk drive data found in system
[UNKNOWN]: Request error: No array controller data returned for API URL '/redfish/v1/Systems/1//SmartStorage/ArrayControllers?$expand=.'

This seems to be a known bug of that BIOS, but they can't upgrade their BIOS right now, so we just removed the --storage, but we still get the UNKNOWN on the --firmware Mode because of Line mentioned above.

Shouldn't it be the other way around, only checking the Firmware of the Drives when also using --storage or --all?

Thanks

[bb-Ricardo]

Hi,

this is indeed a bug. We currently have the same issue/behaviour and hope to fox this soon.

[lgmu]

Alright thanks, as a temp fix I'll just set it to "True" locally

[lgmu]

Any update?
Thanks

[bb-Ricardo]

sorry, no updates for now. haven't had time to look into this.

[bb-Ricardo]

Hi @lgmu,

finally got some time to look into it. I pushed a commit to 'next-release' branch. Can you have a look and test it?

thank you very much.

[bb-Ricardo]

Hi @lgmu: any chance of testing this commit?

[lgmu]

Hi, sorry I was on vacation, I'll try to find time later today and give you feedback!

[lgmu]

Seems to be working fine now, thanks for the fix :)

[bb-Ricardo]

Hey @lgmu,

no need to be sorry for well deserved vacations. Thank you very much for testing it and the feedback, highly appreciated.