Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec: statically reject repeated keyword arguments in call #21

Closed
alandonovan opened this issue Dec 12, 2018 · 3 comments · Fixed by #133
Closed

spec: statically reject repeated keyword arguments in call #21

alandonovan opened this issue Dec 12, 2018 · 3 comments · Fixed by #133

Comments

@alandonovan
Copy link
Contributor

I notice that both Python2 and Python3 statically reject repeated keyword arguments in a call:

% python2 -c 'if False: f(a=1, a=1)'
  File "<string>", line 1
SyntaxError: keyword argument repeated
% python3 -c 'if False: f(a=1, a=1)'
  File "<string>", line 1
SyntaxError: keyword argument repeated

Perhaps Starlark should also. Neither the Go nor Java implementation currently does.

(Note: this issue is independent of the question of whether repeated arguments are checked dynamically when a **kwargs is present in the call.)
@alandonovan alandonovan mentioned this issue Dec 12, 2018
Closed
@laurentlb
Copy link
Contributor

Agree, I think we should do it.

@josharian josharian mentioned this issue Dec 12, 2018
Merged
alandonovan pushed a commit to google/starlark-go that referenced this issue Dec 14, 2018
@adonovan
resolve: statically reject duplicate keyword args in a call
385355a 
This complements the dynamic checks, which is already implemented
in setArgs and in UnpackeArgs.

Updates bazelbuild/starlark#21

Change-Id: If18c9b1f228149b67eca9637050e76e94bd9ff85
@alandonovan alandonovan mentioned this issue Dec 14, 2018
Merged
alandonovan pushed a commit to google/starlark-go that referenced this issue Dec 14, 2018
@adonovan
resolve: statically reject duplicate keyword args in a call (#72)
2c65f9e 
This complements the dynamic checks, which is already implemented in setArgs and in UnpackArgs.

Updates bazelbuild/starlark#21
@alandonovan
Copy link
Contributor Author

OK, this is implemented, tested, and documented in Go.

adonovan added a commit to adonovan/starlark-spec-fork that referenced this issue Nov 13, 2020
@adonovan
spec: duplicate keyword args f(x=1, x=2) is a static error
4c116d7 
This wording comes from google/starlark-go@2c65f9e

Fixes bazelbuild#21

Change-Id: I545111904f25fc0764633f55c5f887706123b0bc
@alandonovan alandonovan mentioned this issue Nov 13, 2020
Merged
@alandonovan
Copy link
Contributor Author

The Java code change was bazelbuild/bazel@9f72d7e

alandonovan pushed a commit that referenced this issue Nov 13, 2020
@adonovan
spec: duplicate keyword args f(x=1, x=2) is a static error (#133)
52bcb15 
This wording comes from google/starlark-go@2c65f9e

Fixes #21
adonovan added a commit to adonovan/starlark-spec-fork that referenced this issue Dec 11, 2020
@adonovan
spec: duplicate keyword args f(x=1, x=2) is a static error (bazelbuil…
ff45083 
…d#133)

This wording comes from google/starlark-go@2c65f9e

Fixes bazelbuild#21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

spec: duplicate keyword args f(x=1, x=2) is a static error adonovan/starlark-spec-fork
2 participants
@laurentlb @alandonovan