Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bazel patch to work around underdefined dependency #146

Conversation

keith
Copy link
Member

@keith keith commented Jan 17, 2023

Fixes https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2824#0185bd7e-6fed-4c16-ad52-256b600d4ae3 for now. Updating bazel requires more work because of third party dependencies:

ERROR: /private/var/tmp/_bazel_ksmiley/430ca27aaa11819957cd32dd0f9637d8/external/io_bazel/third_party/BUILD:464:13: no such package '@maven//': The repository '@maven' could not be resolved: Repository '@maven' is not defined and referenced by '@io_bazel//third_party:guava'

Fixes https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2824#0185bd7e-6fed-4c16-ad52-256b600d4ae3 for now. Updating bazel requires more work because of third party dependencies:

```
ERROR: /private/var/tmp/_bazel_ksmiley/430ca27aaa11819957cd32dd0f9637d8/external/io_bazel/third_party/BUILD:464:13: no such package '@maven//': The repository '@maven' could not be resolved: Repository '@maven' is not defined and referenced by '@io_bazel//third_party:guava'
```
keith referenced this pull request in bazelbuild/bazel Jan 17, 2023
This flag ignores undefined symbols at link time and forces them to be looked up dynamically. This is incompatible with the newer fixup chains macho format and theoretically shouldn't be necessary assuming your dependencies are well defined.

Fixes #16413

Closes #16414.

PiperOrigin-RevId: 501275674
Change-Id: I9240b2596ffea329ef55d3ad15e98635ba8839b6
@keith
Copy link
Member Author

keith commented Jan 17, 2023

@comius

@keith
Copy link
Member Author

keith commented Jan 17, 2023

Copy link
Collaborator

@tetromino tetromino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@tetromino tetromino merged commit 7c5e4fc into bazelbuild:master Jan 17, 2023
@keith keith deleted the ks/add-bazel-patch-to-work-around-underdefined-dependency branch January 17, 2023 16:18
@keith
Copy link
Member Author

keith commented Jan 17, 2023

No problem! Hopefully someone can figure out how to update the bazel pin soon, maybe bzlmod makes that easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants