Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Bump bazel go dependencies #247

Closed
wants to merge 1 commit into from

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Aug 5, 2018

go_repository has been removed from io_bazel_rules_go as of rules_go 0.13.0 (https://github.com/bazelbuild/rules_go/releases/tag/0.13.0). Should now be loaded from @bazel_gazelle//:deps.bzl

Also updated to rules_webtesting 0.2.1 which correctly loads go_repository from @bazel_gazelle//:deps.bzl.

@gregmagolan gregmagolan force-pushed the update-go-deps branch 2 times, most recently from 511669e to 8e70786 Compare August 6, 2018 00:10
@gregmagolan
Copy link
Contributor Author

CI is breaking with the latest rules_go. Issue looks similar to bazelbuild/bazel#5047. Will update CI to bazel 0.16.0 shortly which fixes that issue.

@gregmagolan gregmagolan force-pushed the update-go-deps branch 2 times, most recently from d0ec7f4 to 590760c Compare August 6, 2018 01:18
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update commit message since this is a breaking change

@gregmagolan gregmagolan force-pushed the update-go-deps branch 2 times, most recently from 1547dbc to b2ca13a Compare August 6, 2018 19:21
@gregmagolan
Copy link
Contributor Author

gregmagolan commented Aug 6, 2018

Commit message updated.

Build broken right now on head by 21e7841:

/home/circleci/.cache/bazel/_bazel_circleci/143962326f06c2543998f9d4c1332492/sandbox/processwrapper-sandbox/588/execroot/build_bazel_rules_typescript/ts_auto_deps/analyze/query.go:401:34: undefined: isTazeManagedRuleClass
GoCompile: error running subcommand: exit status 2

BREAKING CHANGE:

@bazel_gazelle is now required in your WORKSPACE file when using rules_typescript:

http_archive(
    name = "bazel_gazelle",
    urls = ["https://github.com/bazelbuild/bazel-gazelle/releases/download/0.13.0/bazel-gazelle-0.13.0.tar.gz"],
    sha256 = "bc653d3e058964a5a26dcad02b6c72d7d63e6bb88d94704990b908a1445b8758",
)

load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")

gazelle_dependencies()
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants