Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Commit

Permalink
Update nodejs_binary entry points to labels
Browse files Browse the repository at this point in the history
Updates to rules_nodejs branch off of 0.30.1 & bazel 0.26.0
  • Loading branch information
gregmagolan committed Jun 2, 2019
1 parent 53245d5 commit 586ec25
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ test --nolegacy_external_runfiles

# Enable the "Managed Directories" feature
build --experimental_allow_incremental_repository_updates
query --experimental_allow_incremental_repository_updates

# Opt-in to upcoming breaking change
build --incompatible_depset_is_not_iterable
4 changes: 2 additions & 2 deletions internal/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ nodejs_binary(
"@npm//source-map-support",
"@npm//typescript",
],
entry_point = "typescript/lib/tsc.js",
entry_point = "@npm//node_modules/typescript:lib/tsc.js",
visibility = ["//internal:__subpackages__"],
)

Expand Down Expand Up @@ -88,7 +88,7 @@ nodejs_binary(
"@npm//typescript",
"//third_party/github.com/bazelbuild/bazel/src/main/protobuf:worker_protocol.proto",
],
entry_point = "build_bazel_rules_typescript/internal/tsc_wrapped/tsc_wrapped.js",
entry_point = ":tsc_wrapped/tsc_wrapped.js",
visibility = ["//visibility:public"],
)

Expand Down
4 changes: 2 additions & 2 deletions package.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ def rules_typescript_dev_dependencies():
_maybe(
http_archive,
name = "build_bazel_rules_nodejs",
sha256 = "bc180118b9e1c7f2b74dc76a8f798d706fe9fc53470ef9296728267b4cd29441",
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.30.2/rules_nodejs-0.30.2.tar.gz"],
urls = ["https://github.com/gregmagolan/rules_nodejs/archive/b6efd596e2a138a26e40e84c9aa0c9166e129cc9.zip"],
strip_prefix = "rules_nodejs-b6efd596e2a138a26e40e84c9aa0c9166e129cc9",
)

# For protocol buffers
Expand Down

0 comments on commit 586ec25

Please sign in to comment.