Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CI tests for versioned releases of Bazel and dependencies. #335

Merged
merged 1 commit into from
Oct 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,44 +25,16 @@ x_defaults:
test_targets: *linux_targets

tasks:
macos_latest:
name: "Latest Bazel"
bazel: latest
<<: *mac_common

macos_last_green:
name: "Last Green Bazel"
bazel: last_green
<<: *mac_common

macos_latest_head_deps:
name: "Latest Bazel with Head Deps"
bazel: latest
shell_commands:
# Update the WORKSPACE to use head versions of some deps to ensure nothing
# has landed on them breaking this project.
- .bazelci/update_workspace_to_deps_heads.sh
<<: *mac_common

ubuntu1804_latest:
name: "Latest Bazel"
bazel: latest
<<: *linux_common

ubuntu1804_last_green:
name: "Last Green Bazel"
bazel: last_green
<<: *linux_common

ubuntu1804_latest_head_deps:
name: "Latest Bazel with Head Deps"
bazel: latest
shell_commands:
# Update the WORKSPACE to use head versions of some deps to ensure nothing
# has landed on them breaking this project.
- .bazelci/update_workspace_to_deps_heads.sh
<<: *linux_common

buildifier:
version: latest
# Disable 'bzl-visibility' since it doesn't work properly.
Expand Down
45 changes: 0 additions & 45 deletions .bazelci/update_workspace_to_deps_heads.sh

This file was deleted.

19 changes: 14 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,23 @@ replacing the `urls` and `sha256` attributes with the values from the release
you wish to depend on:

```python
load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
# rules_swift and apple_support no longer support releases. If you'd like to pin
# down these dependencies to a specific commit, please add the following to the
# top of your WORKSPACE, using the commit you'd like to pin for each of the
# repositories.
git_repository(
name = "build_bazel_rules_swift",
sha256 = "96a86afcbdab215f8363e65a10cf023b752e90b23abf02272c4fc668fcb70311",
urls = [
"https://github.com/bazelbuild/rules_swift/releases/download/0.11.1/rules_swift.0.11.1.tar.gz",
],
remote = "https://github.com/bazelbuild/rules_swift.git",
commit = "[SOME_HASH_VALUE]",
)

git_repository(
name = "build_bazel_apple_support",
remote = "https://github.com/bazelbuild/apple_support.git",
commit = "[SOME_HASH_VALUE]",
)

load(
Expand Down
9 changes: 4 additions & 5 deletions swift/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

"""Definitions for handling Bazel repositories used by the Swift rules."""

load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
load(
"@build_bazel_rules_swift//swift/internal:swift_autoconfiguration.bzl",
Expand Down Expand Up @@ -48,12 +49,10 @@ def swift_rules_dependencies():
)

_maybe(
http_archive,
git_repository,
name = "build_bazel_apple_support",
urls = [
"https://github.com/bazelbuild/apple_support/releases/download/0.7.2/apple_support.0.7.2.tar.gz",
],
sha256 = "9114c452eee622598cf9cdc90ecb12b06af7f914f33440b26deba9a9704d450c",
remote = "https://github.com/bazelbuild/apple_support.git",
branch = "master",
)

_maybe(
Expand Down