Skeleton for multitarget #983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out I made some mistakes on the native toolchain name vs. the implementtion name. Not for the first time. Also had to add TemplateVariableInfo to the core scala_toolchain as required when using the standard toolchains attr. Simply initialized it with an empty map (not really familiar with this provider ...)
…nto factor-toolchains
|
At this point, there's not enough need/support for this (including myself) to continue forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please look at #962 and consider earlier uncommitted PRs first. This PR is based on those PRs and will give you smaller PRs to review.
Description
This is a follow-on to the configuration PR #964 . It shows the basic idea of using a macro shim to create multiple targets based on the configuration.
It works for the current example builds. It should be creating and running parallel subgraphs for each version. It doesn't use toolchains correctly. That is dependent on the toolchain track in #962.
It does include documentation on the approach to give folks a chance to comment on.
I'll work on flushing out the implementation but would welcome thoughts on the approach.