Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiscala configuration #964

Closed
wants to merge 55 commits into from
Closed

multiscala configuration #964

wants to merge 55 commits into from

Commits on Jan 27, 2020

  1. wip

    @smparkes
    smparkes committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    9aee74f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into v2

    @smparkes
    smparkes committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    3091da4 View commit details
    Browse the repository at this point in the history

  3. typo

    @smparkes
    smparkes committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    c1e5f88 View commit details
    Browse the repository at this point in the history

  4. wip

    @smparkes
    smparkes committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    5cccebc View commit details
    Browse the repository at this point in the history

  5. wip

    @smparkes
    smparkes committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    f0d27d8 View commit details
    Browse the repository at this point in the history

  6. wip

    @smparkes
    smparkes committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    8432103 View commit details
    Browse the repository at this point in the history

  7. "unstable"

    @smparkes
    smparkes committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    fe39370 View commit details
    Browse the repository at this point in the history

  8. buildifier

    @smparkes
    smparkes committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    0ef707a View commit details
    Browse the repository at this point in the history

  9. wip

    @smparkes
    smparkes committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    6cffd0d View commit details
    Browse the repository at this point in the history

  10. lint

    @smparkes
    smparkes committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    84e9bfb View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'upstream/master' into configuration

    @smparkes
    smparkes committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    ea51eae View commit details
    Browse the repository at this point in the history

  12. Include toolchains attrs in example 

    Turns out I made some mistakes on the native toolchain name vs. the implementtion name. Not for the first time.

Also had to add TemplateVariableInfo to the core scala_toolchain as required when using the standard toolchains attr.
Simply initialized it with an empty map (not really familiar with this provider ...)
    @smparkes
    smparkes committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    476901e View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2020

  1. very early documentation

    @smparkes
    smparkes committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    3bc7668 View commit details
    Browse the repository at this point in the history

  2. typos and clarity

    @smparkes
    smparkes committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    12a2bba View commit details
    Browse the repository at this point in the history

  3. typo

    @smparkes
    smparkes committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    d6a3f63 View commit details
    Browse the repository at this point in the history

  4. yat: yet another typo

    @smparkes
    smparkes committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    ec684ed View commit details
    Browse the repository at this point in the history

  5. setting to None should remove key, not leave it unchanged

    @smparkes
    smparkes committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    cccf90a View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/master' into configuration

    @smparkes
    smparkes committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    289d9c6 View commit details
    Browse the repository at this point in the history

  7. stupid typo during merge :-(

    @smparkes
    smparkes committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    3ca7ab3 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/master' into configuration

    @smparkes
    smparkes committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    55d16e7 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2020

  1. Merge remote-tracking branch 'upstream/master' into configuration

    @smparkes
    smparkes committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    c89aa79 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into configuration

    @smparkes
    smparkes committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    7a05cbb View commit details
    Browse the repository at this point in the history

  3. thoughts on external repos

    @smparkes
    smparkes committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    ccb535e View commit details
    Browse the repository at this point in the history

  4. editing for typos and clarity

    @smparkes
    smparkes committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    c4086c0 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2020

  1. wip

    @smparkes
    smparkes committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    0aba00e View commit details
    Browse the repository at this point in the history

  2. wip

    @smparkes
    smparkes committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    c830919 View commit details
    Browse the repository at this point in the history

  3. wip

    @smparkes
    smparkes committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    fa7265f View commit details
    Browse the repository at this point in the history

  4. cleanup

    @smparkes
    smparkes committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    052e029 View commit details
    Browse the repository at this point in the history

  5. cleanup

    @smparkes
    smparkes committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    2263bdf View commit details
    Browse the repository at this point in the history

  6. use bind to remove loader-specific labels in dependencies

    @smparkes
    smparkes committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    236cafb View commit details
    Browse the repository at this point in the history

  7. simple test works; //test/... does not

    @smparkes
    smparkes committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    6ef373b View commit details
    Browse the repository at this point in the history

  8. cleanup

    @smparkes
    smparkes committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    794574b View commit details
    Browse the repository at this point in the history

  9. remove scalac provider and use toolchain resolution

    @smparkes
    smparkes committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    7b756bd View commit details
    Browse the repository at this point in the history

  10. put the scalac dep into the toolchain 

    This moves the scalac attr to the toolchain so it can be overriden by
different toolchain implementations.

It also adds a `ScalaInfo` provider level for scala_toolchain to follow the
pattern in the scala docs (rather than flattening into the ToolchainInfo).
    @smparkes
    smparkes committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    fdddc97 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'factor-scalac-provider' into factor-test-toolchain

    @smparkes
    smparkes committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    f7f2fa3 View commit details
    Browse the repository at this point in the history

  12. missed these pieces

    @smparkes
    smparkes committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    c244161 View commit details
    Browse the repository at this point in the history

  13. wip

    @smparkes
    smparkes committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    d68b94c View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2020

  1. cleanup handling of toolchains

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    ac43892 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    578ad8f View commit details
    Browse the repository at this point in the history

  3. unused arguements

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    05ed1e4 View commit details
    Browse the repository at this point in the history

  4. lint

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    a5e38a4 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'factor-toolchains' into factor-scalac-provider

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    df5e833 View commit details
    Browse the repository at this point in the history

  6. lib

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    0d8f08c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'factor-scalac-provider' into factor-test-toolchain

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    bc577ec View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/master' into configuration

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    c4b27ba View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/master' into configuration

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    b738785 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'upstream/master' into bind-dependencies

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    0ab261f View commit details
    Browse the repository at this point in the history

  11. Merge branch 'bind-dependencies' into factor-toolchains

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    5bedbe7 View commit details
    Browse the repository at this point in the history

  12. lint

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    a4b7d3c View commit details
    Browse the repository at this point in the history

  13. Merge branch 'factor-toolchains' of github.com:smparkes/rules_scala i… 

    …nto factor-toolchains
    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    d78dd2c View commit details
    Browse the repository at this point in the history

  14. Merge branch 'factor-toolchains' into factor-scalac-provider

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    8ec626e View commit details
    Browse the repository at this point in the history

  15. Merge branch 'factor-scalac-provider' into factor-test-toolchain

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    e4911c2 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'factor-test-toolchain' into configuration

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    1efa23a View commit details
    Browse the repository at this point in the history

  17. update test toochain name

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    f577d41 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'factor-test-toolchain' into configuration

    @smparkes
    smparkes committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    d3ce09d View commit details
    Browse the repository at this point in the history