Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused method #945

Merged
merged 1 commit into from
Jan 21, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions scala/private/common.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,6 @@ def _collect_jars_when_dependency_analyzer_is_on(dep_targets):
def not_sources_jar(name):
return "-sources.jar" not in name

def filter_not_sources(deps):
return depset(
[dep for dep in deps.to_list() if not_sources_jar(dep.basename)],
)

def add_labels_of_jars_to(jars2labels, dependency, all_jars, direct_jars):
for jar in direct_jars:
jars2labels[jar.path] = dependency.label
Expand Down