Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility test for v1.2.0 #881

Closed
wants to merge 3 commits into from

Conversation

chenrui333
Copy link
Contributor

Description

Fixes #880

Update build config for Bazel 1.1.0 and Bazel 1.2.0

Motivation

Keep up to date with the latest Bazel and meetup is actually actively using this lib.

@chenrui333
Copy link
Contributor Author

Right now we are actually using Bazel 1.1.0 in production, so I am confident with Bazel 1.1.0 upgrade.

But it would be nice to also introduce the compatibility test for Bazel 1.2.0 as well. :)

@chenrui333
Copy link
Contributor Author

Also relates to chenrui333/rules_openapi#22

@ittaiz
Copy link
Member

ittaiz commented Nov 22, 2019

Thanks!
I’d rather we update 1.0.0 to 1.2.0 since our past experience tells us that having too many versions on Travis kills our ability to merge code in easily.

@chenrui333
Copy link
Contributor Author

@ittaiz Sounds totally reasonable. Let me update it.

@chenrui333 chenrui333 changed the title Add compatibility test for Bazel v1.1.0 and v1.2.0 Add compatibility test for v1.2.0 Nov 22, 2019
Copy link
Member

@ittaiz ittaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ittaiz
Copy link
Member

ittaiz commented Nov 22, 2019

build failed. Can you PTAL?

@ittaiz
Copy link
Member

ittaiz commented Nov 22, 2019

We can have two PRs by the way. We can have to upgrade to 1.1.0 and then a followup one to replace it with 1.2.0
If we do that I'd appreciate the diffs to be as small as possible (should be close to replacing 1.0.0 to 1.1.0 and so on)

@chenrui333
Copy link
Contributor Author

Sure. Sounds like a better idea.

@chenrui333
Copy link
Contributor Author

Breakdown the upgrade steps in new PRs, closing this one for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to be compatible with Bazel 1.2.0
3 participants