-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility test for v1.2.0 #881
Conversation
Right now we are actually using Bazel 1.1.0 in production, so I am confident with Bazel 1.1.0 upgrade. But it would be nice to also introduce the compatibility test for Bazel 1.2.0 as well. :) |
Also relates to chenrui333/rules_openapi#22 |
Thanks! |
@ittaiz Sounds totally reasonable. Let me update it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
build failed. Can you PTAL? |
We can have two PRs by the way. We can have to upgrade to 1.1.0 and then a followup one to replace it with 1.2.0 |
Sure. Sounds like a better idea. |
Breakdown the upgrade steps in new PRs, closing this one for now :) |
Description
Fixes #880
Update build config for Bazel 1.1.0 and Bazel 1.2.0
Motivation
Keep up to date with the latest Bazel and meetup is actually actively using this lib.