Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support data files in jmh benchmarks #695

Merged
merged 1 commit into from Feb 21, 2019
Merged

Support data files in jmh benchmarks #695

merged 1 commit into from Feb 21, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 20, 2019

No description provided.

@ghost ghost requested a review from johnynek as a code owner February 20, 2019 13:28
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

Googlers can find more info about SignCLA and this PR by following this link.

@ghost
Copy link
Author

ghost commented Feb 20, 2019

@johnynek feel free to make a copy of this PR, as I'm waiting for our legal department to sign off my contribution - it might be faster if you merge a copy.

Copy link
Member

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I am on vacation today and will merge tomorrow if the CLA has been signed by then.

Thanks again.

@ghost
Copy link
Author

ghost commented Feb 21, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@johnynek johnynek merged commit 1fa4408 into bazelbuild:master Feb 21, 2019
@johnynek
Copy link
Member

Thanks again!

@ghost
Copy link
Author

ghost commented Feb 21, 2019

Thank you for the quick turnaround :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants