Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about updates and usage with bazel-deps to readme #566

Merged
merged 2 commits into from
Aug 6, 2018

Conversation

jhnj
Copy link
Contributor

@jhnj jhnj commented Jul 24, 2018

Add notes to make upgrading rules_scala easier. Based on discussion here: #544 (comment)

@johnynek @ianoc

@jhnj
Copy link
Contributor Author

jhnj commented Jul 24, 2018

Seems like the intellij aspect tests are failing, https://download-cf.jetbrains.com/idea/ideaIC-2018.1.3.tar.gz returns 403

@beala-stripe

@beala-stripe
Copy link
Contributor

Discussed in slack, but wanted to copy it here for visibility.

That looks like a problem with https://github.com/bazelbuild/intellij. rules_scala clones that repo and runs its tests are part of test_intellij_aspect.sh. Those tests depend on that link working. I don't believe this is related to my changes. Could we open an issue/PR in the intellij repo and disable test_intellij_aspect.sh for now?

@jhnj jhnj force-pushed the johan/add-update-notes-to-readme branch from 18cfe7f to 7174949 Compare July 27, 2018 16:51
@johnynek johnynek merged commit 1eab593 into bazelbuild:master Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants