Moving scala junit test from test_rules_scala.sh to RulesScalaIntegra… #503
Conversation
…tionTests.scala using bazel-integration-testing framework
| strip_prefix = "bazel-integration-testing-" + build_bazel_integration_testing_version, | ||
| ) | ||
| load("@build_bazel_integration_testing//tools:repositories.bzl", "bazel_binaries") | ||
| bazel_binaries(versions = ["0.12.0"]) |
There was a problem hiding this comment.
can we make a bazel_version_notes.md or something that lists all the place we need to update when we bump bazel versions?
| "/src/main/java/com/google/devtools/build/lib/bazel/rules/java/" + | ||
| "java_stub_template.txt") | ||
|
|
||
| rules_scala_version = "a8ef632b1b020cdf2c215ecd9fcfa84bc435efcb" |
There was a problem hiding this comment.
this is pretty wild, we are pointing to a previous version of this repo. Can we comment why?
| private def givenRulesScalaWorkspaceFile(): Unit = { | ||
| val workspace = | ||
| """ | ||
| |rules_scala_version="a8ef632b1b020cdf2c215ecd9fcfa84bc435efcb" # update this as needed |
There was a problem hiding this comment.
can we not somehow point to the current version? It feels weird to always be testing a previous version. Also, how updating this seems like a challenge especially if we have many.
|
Hey,
|
|
Sorry I overlooked the comment. I have a bad habit of just reading the code. |
Moving scala junit test from test_rules_scala.sh to RulesScalaIntegrationTests.scala using bazel-integration-testing framework.
Note:
currently it is running the sandbox with a specific commit of rules_scala.
what is left to do is to switch using the local build of rules_scala and move rest of the tests to RulesScalaIntegrationTests.scala
cc: @ittaiz @genrym