Fix thrift bazel incompatibilities #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ittaiz
reviewed
Mar 26, 2018
| @@ -130,16 +139,16 @@ def _gen_scrooge_srcjar_impl(ctx): | |||
| # These are the thrift sources in the dependency graph. They are necessary | |||
| # to generate the code, but are not "owned" by this target and will not | |||
| # be in the resultant source jar | |||
| transitive_thrift_srcs = transitive_owned_srcs + _collect_transitive_srcs(ctx.attr.deps) | |||
| transitive_thrift_srcs = depset(transitive = [transitive_owned_srcs, _collect_transitive_srcs(ctx.attr.deps)]).to_list() | |||
There was a problem hiding this comment.
does this (depset and then to_list) make sense?
There was a problem hiding this comment.
We need to walk the depset eventually, but we do need it as a list. So, I don't know another way.
Note this is semantically a union of two depsets, but union is deprecated now...
I really don't know why they deprecated union when you can implement with depset(transitive = [a, b])... They should be optimizing depset to handle that case...
I'm concerned the bazel folks have not looked at the FP literature on fast immutable types, but maybe they have. I fear they may just be doing immutability with copying.
ittaiz
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the thrift part of #452 to address #430