Strict deps java cmd line flag #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed bazel versions 0.5.3 and 0.5.4 from travis supported versions since above feature mandates 0.6.0 onwards
ittaiz
force-pushed
the
strict_deps_java_command_line_flag
branch
from
8432d88 to
0c9281b
Compare
|
@or-shachar wdyt? |
or-shachar
suggested changes
Oct 23, 2017
There was a problem hiding this comment.
@ittaiz need to add newline at the end of the test script. Does it run without it?
| @@ -583,3 +592,4 @@ $runner test_scala_library_expect_no_recompilation_on_internal_change_of_java_de | |||
| $runner test_scala_library_expect_no_java_recompilation_on_internal_change_of_scala_sibling | |||
| $runner test_scala_library_expect_failure_on_missing_direct_java | |||
| $runner bazel run test:test_scala_proto_server | |||
| $runner test_scala_library_expect_failure_on_missing_direct_deps_warn_mode_java | |||
There was a problem hiding this comment.
@ittaiz missing newline
|
@ittaiz when do you think we should add some docs on using strict deps? I’d like to benchmark it on our largest repo and see if what the perf cost is and what it finds. |
|
see #329
…On Sat, Nov 4, 2017 at 1:10 PM P. Oscar Boykin ***@***.***> wrote:
@ittaiz <https://github.com/ittaiz> when do you think we should add some
docs on using strict deps? I’d like to benchmark it on our largest repo and
see if what the perf cost is and what it finds.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#320 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUIFw-IMnwv5JWeoeYH38-Ol_X0REVVks5szMSugaJpZM4QBz7C>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strict_java_deps for java can be configured via command line
This was pending a change in Bazel to be released in 0.6.0