Reintroduce implicit_compile_deps #1109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts bazelbuild#801 ScalaPB features like extra imports and type mappers don't work with the current implementation of scala_proto_library. This adds back `implicit_compile_deps` tha allows the user to add extra implicit dependencies added to all scala_proto_library targets. Reverted some of the changes in bazelbuild#801. This should work with the latest versions of Bazel since toolchain transitions have been introduced. This is not the ideal solution since changes to theses dependencies will trigger a rebuild of all the proto targets. But it can be an escape hatch for people already using these features and are looking to migrate to Bazel.
|
There's a similar work related to proto toolchains and ability to specify custom deps via toolchain here #1104 . But it's blocked by lack of execution transitions support in older bazel versions. |
|
Closing in favour of #1104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Reverts #801
Why
ScalaPB features like extra imports and type mappers don't work with the current implementation of scala_proto_library.
This adds back
implicit_compile_depstha allows the user to add extra implicit dependencies added to all scala_proto_library targets.How
Reverted some of the changes in #801. This should work with the latest versions of Bazel since toolchain transitions have been introduced.
This is not the ideal solution since changes to theses dependencies will trigger a rebuild of all the proto targets.
But it can be an escape hatch for people already using these features and are looking to migrate to Bazel.