Testing toolchain and Junit deps #1102
Conversation
|
Skimmed it. |
|
My goal is simplicity, I think there's very little gain with having a separate toolchain per test library. From user point of view it's much easier to set up it for cases like specs2 with junit (instead of two toolchains, only one is reaquired). And this is step towards generic testing harness. |
|
I really feel that trying together scalatest with junit goes agaisnt the bazel idioms of separation. |
|
The only thing which is shared is the toolchain type, scalatest rule won't know anything about junit. |
At Twitter, we're looking into using |
|
We do the same for specs2.
We run all of our java junit, scala junit, scala specs2 tests over the
junit runner.
Having said that I don’t think the core junit time should bring specs2 like
it shouldn’t bring scalatest.
Finally the work that Andy started on the genetic testing rule over sbt
test interface is promising.
|
| @@ -31,3 +31,5 @@ def junit_repositories(maven_servers = _default_maven_server_urls()): | |||
| name = "io_bazel_rules_scala/dependency/hamcrest/hamcrest_core", | |||
| actual = "@io_bazel_rules_scala_org_hamcrest_hamcrest_core//jar", | |||
| ) | |||
|
|
|||
| native.register_toolchains("@io_bazel_rules_scala//testing:testing_toolchain") | |||
There was a problem hiding this comment.
This is the default? For people who don't override?
There was a problem hiding this comment.
Yes, but probably it will stay here only until Specs2 and ScalaTest will be migrated. Each test lib will have it's own configuration.
| @@ -0,0 +1,45 @@ | |||
| ## Testing toolchain configuration | |||
There was a problem hiding this comment.
The idea is that Wix can set up a testing toolchain of junit and specs2, twitter of junit and scalatest and stripe only if scalatest?
Since unneeded rules won't be evaluated and the missing deps won't be a problem? If so it will probably be worthwhile to make sure that bazel toolchains actually works like that (for example move scalatest to this and see that Wix defines only specs2 + junit in the single testing toolchain and everything works).
Finally I think it's important in clarifying this idea.
There was a problem hiding this comment.
Toolchain only knows a list of labels, whether it correctly works depends on the actual rule that uses this toolchain and requests any of the dependencies. So if there is no rule that asks for JUnit, there's no need to add Junit deps to the toolchain.
Docs will be updated when there will be more rules that use it.
There was a problem hiding this comment.
I think there's value in explicitly specifying this issue of actual deps.
Most of our users will not understand toolchain in the same depths you do.
* Add testing toolchain with Junit deps * Add docs for junit * Update junit related aspect test deps
This PR is part of refactoring towards toolchains #940
This is a proposal for a generic testing toolchain, which can be used to configure multiple testing libraries. Some users may want to use multiple testing libraries or implementations that depend on Junit. Instead of setting up multiple toolchains (which look very similar), I think it it is more practical to have a single toolchain type, which allows to provide dependencies for mutiple testing libraries.
This PR covers toolchain itself and configuration for JUnit.
Support for ScalaTest and Specs2 will be developed as separate PRs.