Skip to content

Commit

Permalink
Explicitly convert depset to list (#761)
Browse files Browse the repository at this point in the history
This will be required by Bazel 0.27, where the flag
`--incompatible_no_support_tools_in_action_inputs` will be on by
default.

The function `collect_plugin_paths` iterates over its argument, so we
need to flatten the depset.
  • Loading branch information
laurentlb authored and johnynek committed May 31, 2019
1 parent 52b036f commit 7ffc700
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scala/scala_doc.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def _scala_doc_impl(ctx):
compile_jars = depset(transitive = [dep[_ScaladocAspectInfo].compile_jars for dep in ctx.attr.deps])

# Get the 'real' paths to the plugin jars.
plugins = collect_plugin_paths(depset(transitive = [dep[_ScaladocAspectInfo].plugins for dep in ctx.attr.deps]))
plugins = collect_plugin_paths(depset(transitive = [dep[_ScaladocAspectInfo].plugins for dep in ctx.attr.deps]).to_list())

# Construct the full classpath depset since we need to add compiler plugins too.
classpath = depset(transitive = [plugins, compile_jars])
Expand Down

0 comments on commit 7ffc700

Please sign in to comment.