-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid downloading multiple resolvers #694
Avoid downloading multiple resolvers #694
Conversation
44bb5d0
to
812be9b
Compare
Instead, download just the one that's needed for the host platform.
812be9b
to
a4369c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean each crate_universe
repository will download it's own binary? I think this is a step forward but it might be worth having a second repository rule for downloading the resolver and have crate_universe
proper depend on that.
I feel like this would be a pretty quick change, it's just moving the downloading logic into it's own rule. Your thoughts?
Ish - if you set the sha256, bazel should deduplicate the downloads. If you don't, it will probably perform multiple downloads.
I'd rather not invent a separate "avoid downloading the same file multiple times" mechanism, given the sha256 deduping is designed for that, but can add one if you think it'd be a big problem. |
If Bazel will use a cached binary based on the
No, if there's an existing mechanism for doing this that's all I care about. |
Oh crap, this broke bootstrapping. Totally didn't think about that 😞 Can you add a followup PR to update the bootstrap script so users can easily iterate on changes? |
I opened #697 to track the over all plan for CI, but I had setup the bootstrapping to initially solve for this. I wanted to open a PR which runs the bootstrapping script as a shell_command when building examples/crate_universe which would have run as it's own job. Maybe that's a bad idea? We should continue this conversation on the issue I opened or some other one if we want to be more granular. |
Instead, download just the one that's needed for the host platform.
Instead, download just the one that's needed for the host platform.
Fixes #693