Moved proto deps into toolchain to avoid confusing boiler plate code #678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users looking to register their own toolchain sometimes stumble over the fact that every use of
rust_grpc_library
orrust_proto_library
now requires them to also add the appropriate targets to therust_deps
attributes. This is easily missed and not necessary. Instead, these dependencies should be added to the@rules_rust//proto:toolchain
being used so there's a single source of truth for all the dependencies required by these rules.Additionally, this allows users to optionally not register the default toolchain in cases where they want to define their own but would like to ensure other dependencies are brought in.
closes #483