Make toolchain vars available but don't automatically set them #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if a target depended on a toolchain which exposed $(FOO), we would automatically set $FOO as an env var. This was not correct. Toolchains should make Make variables available for expansion in env vars, but should not automatically promote them to action env. If you want $FOO set, you should set $FOO=$(FOO) in the appropriate env var attribute.
illicitonion
force-pushed
the
known-variables
branch
from
0f014db
to
bd79d29
Compare
UebelAndre
approved these changes
Oct 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a target depended on a toolchain which exposed
$(FOO), we would automatically set$FOOas an env var.This was not correct. Toolchains should make Make variables available for expansion in env vars, but should not automatically promote them to action env.
If you want
$FOOset, you should set$FOO=$(FOO)in the appropriate env var attribute.