Build rust_test targets using a crate name different from the underlying lib
#2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeamp
force-pushed
the
add-feature-flag-and-change-rust-test-compilation-output-dir
branch
from
65363ab
to
25d9133
Compare
underlying lib This is a rollforward of bazelbuild#2803, but behind a feature flag. This PR also makes `rust_test` put its compilation outputs in the same directory as the `rust_library` rule (i.e. not in a `test-{hash}` subdirectory anymore). After this change both the `rust_library` and `rust_test` rules will put all its compilation outputs in the same directory, but there won't be any name collisions in non-sandboxed environments (see bazelbuild#1427 for more context). Issue: bazelbuild#2827
felipeamp
force-pushed
the
add-feature-flag-and-change-rust-test-compilation-output-dir
branch
from
25d9133
to
a99f026
Compare
UebelAndre
requested changes
Sep 6, 2024
UebelAndre
requested changes
Sep 10, 2024
There was a problem hiding this comment.
Thanks! Could I also get you to make (or modify an existing) issue ticket to track the new incompatibility flag? We have some guidance on https://github.com/bazelbuild/rules_rust/blob/0.49.3/COMPATIBILITY.md#how-to-make-a-backwards-incompatible-change but since this could be a breaking change we try to give users a chance to raise concerns during the rollout. I've been writing mine to look like #2082
|
I have filed an issue for this, see #2827. Is there anything specific that's missing there? |
felipeamp
force-pushed
the
add-feature-flag-and-change-rust-test-compilation-output-dir
branch
from
61662e9
to
7e498f3
Compare
felipeamp
force-pushed
the
add-feature-flag-and-change-rust-test-compilation-output-dir
branch
from
7e498f3
to
0656abd
Compare
|
I've also fixed the windows tests (that weren't working due to the toolchain binary extension) and added an assert on the directory name as well. |
This was referenced Sep 11, 2024
|
Just gotta resolve the conflicts! |
felipeamp
force-pushed
the
add-feature-flag-and-change-rust-test-compilation-output-dir
branch
from
5c98d7a
to
69e493c
Compare
…nd-change-rust-test-compilation-output-dir
felipeamp
force-pushed
the
add-feature-flag-and-change-rust-test-compilation-output-dir
branch
from
69e493c
to
3986b3b
Compare
|
All done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rollforward of
#2803, but behind the
incompatible_change_rust_test_compilation_output_directoryincompatible flag.This PR also makes
rust_testput its compilation outputs in the same directory as therust_libraryrule (i.e. not in atest-{hash}subdirectory anymore).After this change both the
rust_libraryandrust_testrules will put all its compilation outputs in the same directory, but there won't be any name collisions in non-sandboxed environments (see #1427 for more context).Issue with context: #2827