Use pub(crate) rather than pub #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
approved these changes
Feb 28, 2024
|
I think the before was maybe a bit lazy, but also honestly fine? But happy to merge and see how we go! |
Now that we actually have some pub items, this will help us to avoid accidentally leaking more (e.g. in bazelbuild#2515 we are leaking `CrateId`, `Select`, and `CrateDependency` to be public because they're marked `pub` not `pub(crate)`. I'm not sure I like this, but wanted send as an RFC to discuss.
illicitonion
force-pushed
the
pub-crate-all-the-things
branch
from
b909473
to
5e5189b
Compare
qtica
added a commit
to qtica/rules_rust
that referenced
this pull request
Apr 1, 2024
Now that we actually have some pub items, this will help us to avoid accidentally leaking more (e.g. in bazelbuild#2515 we are leaking `CrateId`, `Select`, and `CrateDependency` to be public because they're marked `pub` not `pub(crate)`. I'm not sure I like this, but wanted send as an RFC to discuss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we actually have some pub items, this will help us to avoid accidentally leaking more (e.g. in
#2515 we are leaking
CrateId,Select, andCrateDependencyto be public because they're markedpubnotpub(crate).I'm not sure I like this, but wanted send as an RFC to discuss.