Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cc toolchain files to rustc dependencies (for linker) #217

Merged
merged 4 commits into from
May 9, 2019
Merged

Add cc toolchain files to rustc dependencies (for linker) #217

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b0cd1c
Add cc toolchain files to rustc dependencies (for linker)
m3rcuriel Apr 23, 2019
f617724
Add TODO comment for migration to all_files
m3rcuriel Apr 24, 2019
de1af60
Wrap ctx.files._cc_toolchain in a depset
m3rcuriel May 7, 2019
8363428
Add cc toolchain
m3rcuriel May 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rust/private/rustc.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,8 @@ def rustc_compile_action(
transitive = [
toolchain.rustc_lib.files,
toolchain.rust_lib.files,
],
# TODO wait for CcToolchainInfo.all_files to be available
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TODO wait for CcToolchainInfo.all_files to be available
# C++ library linked in rust libraries need the linker to be available at compile-time.
# TODO: Switch to CcToolchainInfo.all_files once available.

] + ctx.files._cc_toolchain,
m3rcuriel marked this conversation as resolved.
Show resolved Hide resolved
)

args = ctx.actions.args()
Expand Down