-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced crates_universe
rule with crates_repository
#1158
Conversation
68825c5
to
293e821
Compare
293e821
to
33a6852
Compare
b401446
to
ebe8ad5
Compare
ebe8ad5
to
2f89eb4
Compare
@illicitonion would likely be the best reviewer since, to my knowledge, they're avid consumers of I tried to refactor this PR into small sections to make this easier to review. Each commit should be reviewed individually and anything that refers to "Updating lockfiles" is a commit containing generated content and is probably not worth digging into after confirming the code changes are in a good state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Curious, what is the relationship between |
My team and I put together |
This PR replaces the existing
crate_universe
rules and binaries with https://github.com/abrisco/cargo-bazel which is an equivalent tool that generally solves for the same desires and is more self-contained.