Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runfiles lib #982

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Update runfiles lib #982

merged 2 commits into from
Jan 12, 2023

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Jan 11, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

rules_python's runfiles library is affected by bazelbuild/bazel#14336, which has been fixed upstream.

What is the new behavior?

rules_python's version of the runfiles library contains bazelbuild/bazel@486d153

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Also adds the tests contained in the Bazel repo.

@fmeum fmeum requested a review from rickeylev as a code owner January 11, 2023 21:49
@fmeum
Copy link
Contributor Author

fmeum commented Jan 11, 2023

@alexeagle This is the first commit with changes backported (?) from Bazel. I will start adding the Bzlmod changes as follow-ups.

@fmeum
Copy link
Contributor Author

fmeum commented Jan 11, 2023

Is there a canonical way to format Python files? The runfiles library differs from the Bazel Core one in this regard and I would like to stay consistent with the formatting style used in this repo.

@alexeagle
Copy link
Collaborator

You can install pre-commit.com and run 'pre-commit install' for our typical flow. It just uses black and there's no CI enforcement IIRC

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I assume this was already reviewed when it was changed upstream so we are just updating our vendored copy

@fmeum fmeum force-pushed the update-runfiles-lib branch from 18dc177 to b220689 Compare January 12, 2023 00:24
@fmeum
Copy link
Contributor Author

fmeum commented Jan 12, 2023

I ran the formatters.

@alexeagle
Copy link
Collaborator

Thanks!

@alexeagle alexeagle merged commit 7e2d4ec into bazelbuild:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants