Remove duplicate method invocation in entry_point generation #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thundergolfer
requested review from
f0rmiga and
hrfuller
and removed request for
brandjon and
lberki
thundergolfer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Duplicate method invocation.
#675 introduced the return code handling.
https://github.com/bazelbuild/rules_python/pull/573/files#diff-cd80d344159f5c70b91dfc2caee848739096387abeda9152d53f601c812b41eaR38 removed the unnecessary type-check but intro'd the 🐛.
Issue Number: #675
What is the new behavior?
Only execute the method once.
Does this PR introduce a breaking change?
Other information