Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-platform torch example #2449

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

keith
Copy link
Member

@keith keith commented Nov 27, 2024

This has been a useful starting point for me locally to repro pypi
downloader issues we see in our project.

@keith
Copy link
Member Author

keith commented Nov 27, 2024

should fail because of #2446

@keith
Copy link
Member Author

keith commented Nov 27, 2024

ideally after that one is fixed we could make it fail for this issue as well: #2450

currently that takes doing a query though

@keith keith force-pushed the ks/add-multi-platform-torch-example branch from 1ac2e4e to caf3c73 Compare December 2, 2024 21:33
keith added 2 commits December 9, 2024 20:33
This has been a useful starting point for me locally to repro pypi
downloader issues we see in our project.
@keith keith force-pushed the ks/add-multi-platform-torch-example branch from caf3c73 to 5c57c19 Compare December 9, 2024 20:34
@aignas
Copy link
Collaborator

aignas commented Dec 12, 2024

I am hesitant to add yet another example because we have many examples and not enough CI slots (or at least at some point I've heard that) and most of the cases present in the example already have unit tests, so I am not sure if this is adding anything on top of what is present in bzlmod example.

That said, the pytorch usecase has come up enough times, that I think we should probably update the bzlmod example to use pytorch as part of deps. The only annoying thing being that pytorch wheels are huge and the testing will take longer to just test requirements wiring bits, which is already covered by unit tests as I said previously.

Given that #2488 fixes the original issue, I would be willing to repurpose this work as a section in our docs on using PyPI deps. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants