Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gazelle): Rename GAZELLE_VERBOSE env var; use idiomatic go; add comments #2428

Merged
merged 5 commits into from
Nov 20, 2024
Merged

chore(gazelle): Rename GAZELLE_VERBOSE env var; use idiomatic go; add comments #2428

merged 5 commits into from
Nov 20, 2024

Conversation

dougthor42
Copy link
Contributor

Address PR comments from #2420:

  • Add and update comments
  • idiomatic go: return early
  • rename and document env var

@dougthor42 dougthor42 marked this pull request as ready for review November 19, 2024 23:47
@aignas aignas enabled auto-merge November 20, 2024 04:59
@aignas aignas added this pull request to the merge queue Nov 20, 2024
Merged via the queue into bazelbuild:main with commit 4a55ef4 Nov 20, 2024
4 checks passed
@dougthor42 dougthor42 deleted the u/dthor/pr-comments branch November 20, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aignas aignas aignas approved these changes

@f0rmiga f0rmiga Awaiting requested review from f0rmiga

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougthor42 @aignas