Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add last_rc, remove extraneous pystar configs #2405

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

rickeylev
Copy link
Collaborator

@rickeylev rickeylev commented Nov 13, 2024

Run the bzlmod example with last_rc to match the BCR config. This should help catch any
issues before a BCR release occurs.

Along the way, cleanup the extraneous pystar configs. The rules_python Starlark
implementation is enabled by default, and disabling it is unsupported.

@rickeylev rickeylev force-pushed the bazel8.windows.bzlmod.example branch 2 times, most recently from ad56786 to 52889ee Compare November 14, 2024 00:15
@rickeylev rickeylev changed the title wip: test bazel8, windows, bzlmod ci: add last_rc, remove extraneous pystar configs Nov 14, 2024
@rickeylev rickeylev marked this pull request as ready for review November 14, 2024 00:22
@rickeylev rickeylev requested a review from aignas as a code owner November 14, 2024 00:22
@rickeylev rickeylev enabled auto-merge November 14, 2024 00:22
@rickeylev rickeylev force-pushed the bazel8.windows.bzlmod.example branch from 52889ee to 2f82a5d Compare November 14, 2024 00:37
@rickeylev rickeylev added this pull request to the merge queue Nov 14, 2024
Merged via the queue into bazelbuild:main with commit 273cbd1 Nov 14, 2024
4 checks passed
@rickeylev rickeylev deleted the bazel8.windows.bzlmod.example branch December 6, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants