fix(precompiling): only add pyc to default outputs if precompiling explicitly enabled for target #2307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where precompiled files were always being added to the default outputs
of a target. The intent is they are only added to a target's default outputs if the
target explicitly opted into precompiling. This went unnoticed because the exec tools
toolchain is still disabled by default, so the test that verifies a basic py_binary's
default outputs didn't generate implicit pyc files. It was introduced when fixing the
pyc collection bug.
To fix, only add the pyc files deemed "required", not all the pyc files generated.
Also added a test to capture this case to the precompile tests.