fix(toolchain): delete 'share/terminfo' for recent linux python toolchains #1898
+73
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hains This affects Linux toolchains that have the `terminfo` databases bundled with the toolchain. Our solution to this is to remove the `share/terminfo` altogether if we are downloading an affected `linux` toolchain. Workaround indygreg/python-build-standalone#231 Fixes bazelbuild#1800
rickeylev
approved these changes
May 14, 2024
chasezheng
added a commit
to chasezheng/rules_python
that referenced
this pull request
Sep 22, 2024
Upstream fix in bazelbuild#1898
chasezheng
added a commit
to chasezheng/rules_python
that referenced
this pull request
Sep 22, 2024
Upstream fix in bazelbuild#1898
chasezheng
added a commit
to chasezheng/rules_python
that referenced
this pull request
Sep 22, 2024
Upstream fix in bazelbuild#1898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects Linux toolchains that have the
terminfodatabases bundledwith the toolchain. Our solution to this is to remove the
share/terminfoaltogether if we are downloading an affectedlinuxtoolchain.
Tested with (on a Mac):
Workaround indygreg/python-build-standalone#231
Fixes #1800