Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gazelle): Consistent substitution pattern for python_default_visibility directive #1835

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

dougthor42
Copy link
Collaborator

@dougthor42 dougthor42 commented Apr 6, 2024

Make the substitution pattern for python_default_visibility consistent
with the existing python_*_naming_convention pattern.

In #1787 I added the python_default_visibility directive and used a
substitution pattern $python_root. However, I missed that the existing
python_*_naming_convention directives include a trailing $.

This PR is just:

rg -l -F "\$python_root" | xargs sed -i 's/\$python_root/$python_root$/g'

…directive consistent with existing python_*_naming_convention
@dougthor42 dougthor42 force-pushed the replacement-pattern branch from 9f54a61 to d9b4d54 Compare April 6, 2024 21:36
@dougthor42 dougthor42 marked this pull request as ready for review April 6, 2024 21:37
@dougthor42 dougthor42 requested a review from f0rmiga as a code owner April 6, 2024 21:37
@dougthor42
Copy link
Collaborator Author

Notes:

  1. We should get this in before 0.32.0 release so that there doesn't have to be any deprecation timeline.
  2. I figured this didn't need a changelog entry because it's just part of adding the python_default_visibility directive.

@aignas aignas added this pull request to the merge queue Apr 7, 2024
Merged via the queue into bazelbuild:main with commit 24a910d Apr 7, 2024
4 checks passed
@dougthor42 dougthor42 deleted the replacement-pattern branch April 7, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants